Build XDP depending on XRT component being built #8695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change how XDP is built in XRT. Infer XDP build options based on which component is being built. XDP is included in the npu and alveo components and the in the legacy xrt component, but it is being built differently depending on the component. XDP is excluded from XRT's base component. This PR infers compile flags for XDP based on the component. XDP_CLIENT_BUILD_CMAKE is now an internal configuration variable for XDP. There are no visible changes in this PR. However, anything invoking CMake with XDP_CLIENT_BUILD_CMAKE will be affected and must change to ensure that XRT is building the NPU component by adding `-DXRT_NPU` when invoking CMake. Signed-off-by: Soren Soe <[email protected]>
The variable that define what components of XRT to build must be set up always otherwise pieces of XRT will fail to build. Simplify how runtime_src/xdp decides to build legacy XRT. XRT_ALVEO is inferred for legacy XRT so no need to check for XRT_XRT. Signed-off-by: Soren Soe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Change how XDP is built in XRT. Infer XDP build options based on which component is being built.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
XDP is included in the npu and alveo components and the in the legacy xrt component, but it is being built differently depending on the component. XDP is excluded from XRT's base component.
How problem was solved, alternative solutions (if any) and why they were rejected
This PR builds on #8691. It includes XDP in
npu,alveo, and legacyxrtcomponents, but excludes XDP frombase. Compile flags for XDP are based on the component. XDP_CLIENT_BUILD_CMAKE is now an internal configuration variable for XDP.There are no visible changes in this PR. However, anything invoking CMake with XDP_CLIENT_BUILD_CMAKE will be affected and must change to ensure that XRT is building the NPU component by adding
-DXRT_NPUwhen invoking CMake.